Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closes #2024 by documenting and testing 'method' field in z_getoperationstatus #2069

Merged
merged 1 commit into from Feb 8, 2017
Merged

Closes #2024 by documenting and testing 'method' field in z_getoperationstatus #2069

merged 1 commit into from Feb 8, 2017

Conversation

bitcartel
Copy link
Contributor

No description provided.

@bitcartel bitcartel added A-documentation Area: Documentation A-rpc-interface Area: RPC interface A-testing Area: Tests and testing infrastructure labels Feb 6, 2017
@bitcartel bitcartel added this to the 1.0.6 milestone Feb 6, 2017
@bitcartel bitcartel added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 7, 2017
str4d
str4d approved these changes Feb 8, 2017
View reviewed changes
Copy link
Contributor

@str4d str4d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ut(ACK+cov)

daira
daira approved these changes Feb 8, 2017
View reviewed changes
Copy link
Contributor

@daira daira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK.

@bitcartel
Copy link
Contributor Author

@zkbot r+

@zkbot
Copy link
Contributor

zkbot commented Feb 8, 2017

📌 Commit aa0ab69 has been approved by bitcartel

@zkbot
Copy link
Contributor

zkbot commented Feb 8, 2017

⌛ Testing commit aa0ab69 with merge 904c19d...

zkbot added a commit that referenced this pull request Feb 8, 2017
@zkbot
Auto merge of #2069 - bitcartel:2024_document_test_method_field_getop…
904c19d 
…erationstatus, r=bitcartel

Closes #2024 by documenting and testing 'method' field in z_getoperationstatus
@zkbot
Copy link
Contributor

zkbot commented Feb 8, 2017

☀️ Test successful - zcash

@zkbot zkbot merged commit aa0ab69 into zcash:master Feb 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daira daira daira approved these changes

@str4d str4d str4d approved these changes

@nathan-at-least nathan-at-least Awaiting requested review from nathan-at-least

Assignees
No one assigned
Labels
A-documentation Area: Documentation A-rpc-interface Area: RPC interface A-testing Area: Tests and testing infrastructure S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Milestone
1.0.6
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@bitcartel @zkbot @daira @str4d